feat: cleanup onchain legacy AidEscrow documentation and tests#137
Open
Markadrian6399 wants to merge 1 commit intoPulsefy:mainfrom
Open
feat: cleanup onchain legacy AidEscrow documentation and tests#137Markadrian6399 wants to merge 1 commit intoPulsefy:mainfrom
Markadrian6399 wants to merge 1 commit intoPulsefy:mainfrom
Conversation
- Updated README.md with complete method reference table (15 methods) - Added data structure documentation (Package, PackageStatus, Config, Aggregates) - Updated CONTRIBUTING.md code examples with current method signatures - Added comprehensive tests for batch_create_packages - Added tests for extend_expiration (success and error cases) - Added tests for get_aggregates with state transitions - Added tests for set_config and get_config - All 43 tests passing - Code formatted and clippy clean Resolves onchain module cleanup requirements for legacy design references
Cedarich
approved these changes
Feb 24, 2026
Contributor
|
please resolve conflicts |
Contributor
|
Please resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves onchain module cleanup requirements for legacy design references
closes #127