Skip to content

feat(command): expose plugin suggestion callbacks - #12

Open
NicDevTV wants to merge 1 commit into
Pumpkin-MC:masterfrom
NicDevTV:feat/plugin-command-suggestions-wit
Open

feat(command): expose plugin suggestion callbacks#12
NicDevTV wants to merge 1 commit into
Pumpkin-MC:masterfrom
NicDevTV:feat/plugin-command-suggestions-wit

Conversation

@NicDevTV

@NicDevTV NicDevTV commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds WIT support for plugin-provided command suggestions.

This introduces suggestion request/result types and a new command-node hook so plugins can attach server-side suggestion handlers to command arguments. The plugin world now exports handle-command-suggestion, allowing Pumpkin to ask the plugin for completions when a Java client requests minecraft:ask_server suggestions.

This is needed for plugin commands with custom argument grammars, such as weighted block patterns like 50%stone,50%dirt, where normal block-state completion is not enough because only the active pattern segment should be replaced.

Testing

  • Consumed by the Pumpkin implementation in the dependent PR
  • cargo check -p pumpkin-plugin-api
  • cargo check -p pumpkin

@vyPal vyPal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix merge conflicts

@NicDevTV

NicDevTV commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

I will asap when I’m back from vacation in 7 days @vyPal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants