feat(command): expose plugin suggestion callbacks - #12
Open
NicDevTV wants to merge 1 commit into
Open
Conversation
vyPal
approved these changes
Aug 8, 2026
vyPal
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please fix merge conflicts
Contributor
Author
|
I will asap when I’m back from vacation in 7 days @vyPal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds WIT support for plugin-provided command suggestions.
This introduces suggestion request/result types and a new command-node hook so plugins can attach server-side suggestion handlers to command arguments. The plugin world now exports
handle-command-suggestion, allowing Pumpkin to ask the plugin for completions when a Java client requestsminecraft:ask_serversuggestions.This is needed for plugin commands with custom argument grammars, such as weighted block patterns like
50%stone,50%dirt, where normal block-state completion is not enough because only the active pattern segment should be replaced.Testing
cargo check -p pumpkin-plugin-apicargo check -p pumpkin