fix(wit): replace position tuple with record, remove deprecated raw-text-component type - #21
Open
AmmarDeeper34 wants to merge 6 commits into
Open
fix(wit): replace position tuple with record, remove deprecated raw-text-component type#21AmmarDeeper34 wants to merge 6 commits into
AmmarDeeper34 wants to merge 6 commits into
Conversation
…ext-component type - Change position from tuple<f64,f64,f64> to record with named x,y,z fields - Remove deprecated raw-text-component type alias - Breaking ABI change: plugins must recompile against new WIT definitions Refs: #449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of Pumpkin #2507 — Pumpkin 1.0.0 Roadmap (Issue #449).
Changes
Replace
positiontuple with record inv0.1/common.wit:type position = tuple<f64, f64, f64>;record position { x: f64, y: f64, z: f64 }Remove deprecated
raw-text-componenttype (unused type alias).Rationale
raw-text-componenttype was unused (replaced bytext-componentresource)Breaking Change
Existing WASM plugins using
Positionas a tuple will need to switch to field access (.x,.y,.z).