Fix test ID resolution by deployment name (2.0.3) - #5
Merged
Conversation
Use absolute GitHub URL instead of relative path that breaks on PyPI.
Hex hashes like '764303e9' are parsed as floating point (7.64303e+9) by YAML 1.1 parsers, causing invalid Kubernetes job names. Ensure the hash always starts with a letter by sliding the 8-char window. Bump version to 2.0.2.
resolve_test_id now passes deployment_name to the K8s lookup, preventing a running job from a different config from shadowing the correct results. Bump version to 2.0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_test_idto filter K8s job lookups bydeployment_name, preventing a running job from a different config from shadowing the correct stored resultsTest plan