Delete pre_build's two dead failure-tolerant sites (audit step 1)#158
Merged
Conversation
Per the audit merged in #157 (docs/pre_build_failure_audit.md): the root-glob staging line was a measured no-op in all 13 repos (unmatched globs poison the whole pathspec, exit 128 swallowed by || true), and the README version bump's sed output was never staged while the runner-side bump was removed under #120 — the banner printed a false claim on every release. Both sites deleted along with the unused readme_pkg parameter and its 13 call-site args; skill doc and internals.md synced (including the stale pre-#150 "git add -f dataset" claim). Behaviour on main unchanged by construction: neither site produced anything that ever landed. README-pin ownership moves to campaign Phase 4 (#155). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 1 of the design merged in #157 (
docs/pre_build_failure_audit.md; issue #156, campaign #155): delete the two dead failure-tolerant sites inpre_build.sh, measured no-ops before deletion:git add -- *.py *.md … || true) — exit 128 / staged nothing in 13/13 repos (six of its globs match nothing in any repo, poisoning the whole pathspec);readme_pkgparameter and all 13 call-site args — its sed edit was never staged (dead glob line), the runner-side bump was removed under feat: release stamping slim — wheels+tags only, no daily bump commits (R3-core) #120, and the pins it targeted are proven stale on origin. The banner printed a false claim on every release; README-pin ownership is a Phase 4 decision (release_version_sync_back_to_main.md).Doc syncs ride along: the pre_build skill's step description and stale "README version-bump is handled inside pre_build.sh" note;
docs/internals.md's stale "dataset force-added withgit add -f" claim (pre-#150) and root-level-files row (now owned by the runner).Behaviour on main is unchanged by construction: both deleted sites provably staged/produced nothing that ever landed. The only local difference is that READMEs no longer get dirty-edited-then-dropped on each release.
Steps 2 (own the runner's
git add -Asweep) and 3 (shrink pre_build to its genuine product) follow as separate planned PRs.Shipped under the human-authorized corrective-PR exception for Heart RED (standing authorization this session; "merge and continue" instruction 2026-07-16). PR-open only; merge stays human.
API Changes
None — release-script internals and docs only.
run_workspaceloses its unused 5th positional arg (readme_pkg); all call sites updated in the same file.Test Plan
bash -n pre_build.sh— syntax OK.test_pre_build_skilldrift guard, which parsespre_build.sh'srun_workspacelines and$PYAUTOBASEdeps).git add -nexit-code matrix (13/13 exit 128 on the glob line); origin-verified stale pins showing the sed's output never landed.Generated by the PyAutoLabs agent workflow.