Shrink pre_build to what its run produces (audit step 3)#160
Merged
Conversation
Human-decided (2026-07-16): delete the dataset/config sweep vestige. black runs on the staged dirs only (scripts/, slam_pipeline/) instead of ".", the dataset/ and config/ adds are removed (they staged nothing the run produced — sweeping human dirt into release commits was the #126 leak mechanism; Heart gates on clean mains), the staging loop's latent [ -d ] && fatal idiom is now an explicit if, and generate.py's os.system("git add -f ...") becomes a checked subprocess.run without -f (measured: start_here.ipynb tracked and unignored everywhere it exists). Allowlist check retained. Skill doc synced. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Jammy2211
added
the
pending-release
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 3 of the audit design (#156/#157; campaign #155), with the open §6 decision resolved by the human (2026-07-16): delete the sweep vestige. pre_build now touches only what its run produces:
black .→ black on the staged dirs only (scripts/,slam_pipeline/). Blacking "." reformatted 13 files no staging rule covered (HowTo*.github/scripts/,autoassistant/), leaving them perpetually dirty-local on every release.dataset/andconfig/adds are deleted. Nothing in the run modifies them; their only function was sweeping pre-existing human-uncommitted work into release commits — the bug: release pipeline force-commits simulated workspace datasets (git add -f) #126 leak mechanism. Releases require clean mains (Heart gates on it); human work is committed by humans. The dataset allowlist check stays (it guards tracked data regardless of staging).[ -d "$d" ] && git addidiom → explicitif(removes the latent bug-1-class fatal on a present-but-fully-ignored dir).generate.py:os.system(f"git add -f {notebook}")→subprocess.run([...], check=True)without-f. Measured before dropping the force flag:start_here.ipynbis tracked and unignored in every workspace that has one; a real add failure now raises instead of vanishing into an ignored return.With this, every failure-tolerant site the audit enumerated is resolved:
:55/:88deleted (#158), the runner sweep owned (#159),:82made explicit,generate.py:107checked. The remaining|| true(:79shape) is gone with the dataset add itself.Shipped under the human-authorized corrective-PR exception for Heart RED (standing this session). PR-open only; merge stays human.
API Changes
None — release-script internals. Behavioural deltas, deliberate and human-decided: pre_build no longer commits pre-existing dirt in
dataset//config/, and no longer reformats files outsidescripts//slam_pipeline/.Test Plan
bash -n pre_build.sh;ast.parse(generate.py).-fdrop measured safe:git check-ignore start_here.ipynbclean + tracked in all 5 repos that carry one.notebooks//scripts//slam_pipeline/paths.Generated by the PyAutoLabs agent workflow.