refactor: remove the NSS nested sampler and its [nss] extra#1357
Merged
Conversation
Removes af.NSS and the autofit/non_linear/search/nest/nss module, its tests, the [nss] optional-dependency extra (the git+ direct-URL footgun) and the AGENTS.md install notes. The bespoke install/CI/build machinery NSS required was not justified by its measured performance; it can return as a genuine pip install later. The implementation is preserved verbatim in autofit_workspace_developer/searches/nss/ for re-mainlining. Public API removal: af.NSS. blackjax stays (BlackJAXNUTS uses it). Issue: #1356 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 11, 2026
Merged
This was referenced Jul 11, 2026
refactor: drop NSS references from CI-status test + release-validation doc
PyAutoLabs/PyAutoHeart#60
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the NSS nested slice sampler (
af.NSS) and all of its supporting machinery. The bespoke git+ install / CI / build apparatus it required was never justified by its measured performance (mixed — faster per-eval on MGE but OOM-prone on pixelization/Delaunay via vmap fan-out); it can return later as a genuine PyPI install. The full implementation is preserved for re-mainlining (see below).Closes the PyAutoFit slice of #1356.
API Changes
af.NSS(and theautofit/non_linear/search/nest/nss/module:search.py,samples.py,_chunked_nss.py,_chunked_update.py).[nss]optional-dependency extra (the git+ direct-URL footgun) and its install notes frompyproject.toml+AGENTS.md.blackjax>=1.2.0retained in[optional]—af.BlackJAXNUTSuses it. No other public API changes.Preserved for reuse
The working implementation is stashed in
autofit_workspace_developer/searches/nss/(companion PR) — module relativized as a drop-in, tests verbatim, README with the pinnedhandley-lab/blackjax+yallup/nssSHAs and a re-mainline checklist.Validation
test_autofit/: 1471 passed, 1 skipped, 0 failed.autogalaxy+autolensimport cleanly against the NSS-removedautofit;af.NSSconfirmed gone; grep-clean of any NSS reference in both.Reviewer checklist
af.NSSremoval is intended (returns later as a real pip package)blackjaxcorrectly retained for NUTS🤖 Generated with Claude Code
https://claude.ai/code/session_01Y9eyGoEAUHGSqcmJpzzjsi