refactor: retire the NSS profiling runs#65
Merged
Conversation
Removes NSS from the profiling framework now that af.NSS is gone (PyAutoFit#1356, Phase 5 — the final piece): the searches/nss/ cell subtree (9 files), the 9 nss sweep cells, build_nss + _NSS_DEFAULTS + the "nss" SAMPLER_BUILDERS registration, the _runner nss settings branch, the 3 nss A100 HPC submit scripts, and the nss mentions in README / hpc README. Kept as historical evidence: results/notes/sparse_vs_dense_inversion_path.md (A100 fp64 NSS validation table) and the HPC JAX venv reference (used for all GPU profiling; NSS-derived name only). Issue: PyAutoFit#1356 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final phase of the NSS removal (PyAutoLabs/PyAutoFit#1356, Phase 5). Removes NSS from the profiling framework now that
af.NSSis gone.Changes
searches/nss/cell subtree (9 files) + the 9("nss", …)cells fromsweep.py.searches/_samplers.py— removedbuild_nss,_NSS_DEFAULTS, and the"nss"entry inSAMPLER_BUILDERS.searches/_runner.py— removed the_NSS_DEFAULTSimport and thesampler == "nss"settings branch.hpc/batch_gpu/submit_nss_*A100 submit scripts; de-NSS'd thehpc/README.mdsubmit-prefix note and theREADME.mdsampler list.Kept (historical / still-used)
results/notes/sparse_vs_dense_inversion_path.md— the A100 fp64 NSS validation data (evidence)./mnt/ral/.../PyAutoNSS/HPC venv reference in the skill — that venv drives all GPU profiling (nautilus included); only its name is NSS-derived.Validation
test/: 26 passed. Modules parse;SAMPLER_BUILDERS/CELLSnow nautilus-only; grep-clean of NSS (bar the kept historical note +FitPositionsSourcefalse positives).Once merged, PyAutoLabs/PyAutoFit#1356 can close — this was the last blocked phase.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y9eyGoEAUHGSqcmJpzzjsi