test: document JAX finite-difference branch flip#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
galaxies.lens.mass.einstein_radiusin theRectangularKernelAdaptDensity (os_pix=1, bandwidth=0.1)gradient checkScripts Changed
scripts/jax_grad/imaging_pixelization.py— resolve the FD-unreliable parameter by name for the affectedos_pix=1variant, document the cross-version/ULP evidence, and report the exclusion explicitlyscripts/jax_grad/util.py— clarify thatskip_indicescovers documented unreliable comparisons, including finite differences that cross a discontinuityCorrective-PR exception
release validation FAILED (stage integrate)jax_gradfailure → issue fix: investigate JAX gradient mismatch at parameter 9 #164 plan → this two-script, parameter-specific diffPyAutoFit: 1 commit(s) behind originTest Plan
scripts/jax_grad/imaging_pixelization.pyend-to-end with JAX/JAXLIB 0.10.2 (pass; documented parameter-9 FD exclusion exercised)scripts/jax_grad/interferometer.pywith JAX/JAXLIB 0.10.2 (pass)git diff --checkValidation checklist (--auto run — plan was not pre-approved)
release validation FAILED (stage integrate)Generated by the PyAutoLabs agent workflow.