Skip to content

test: document JAX finite-difference branch flip#165

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/jax-grad-param9-mismatch
Jul 14, 2026
Merged

test: document JAX finite-difference branch flip#165
Jammy2211 merged 1 commit into
mainfrom
feature/jax-grad-param9-mismatch

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

  • identify parameter 9 as galaxies.lens.mass.einstein_radius in the RectangularKernelAdaptDensity (os_pix=1, bandwidth=0.1) gradient check
  • confirm JAX 0.9.2 and 0.10.2 return the same autodiff value, ruling out a JAX 0.10.2 autodiff regression
  • document the JAX 0.10.2 finite-difference branch flip and exclude only that named comparison while retaining its printed measurement and every other gradient, liveness, and FoM assertion

Scripts Changed

  • scripts/jax_grad/imaging_pixelization.py — resolve the FD-unreliable parameter by name for the affected os_pix=1 variant, document the cross-version/ULP evidence, and report the exclusion explicitly
  • scripts/jax_grad/util.py — clarify that skip_indices covers documented unreliable comparisons, including finite differences that cross a discontinuity

Corrective-PR exception

Test Plan

  • Run scripts/jax_grad/imaging_pixelization.py end-to-end with JAX/JAXLIB 0.10.2 (pass; documented parameter-9 FD exclusion exercised)
  • Run the same imaging script end-to-end with isolated JAX/JAXLIB 0.9.2 (pass; autodiff value matches 0.10.2)
  • Run sibling scripts/jax_grad/interferometer.py with JAX/JAXLIB 0.10.2 (pass)
  • Run all six workspace smoke sets (52 passed, 0 failed, 3 declared skips)
  • Compile both changed scripts and run git diff --check
  • Independent review verdict: CLEAN

Validation checklist (--auto run — plan was not pre-approved)

  • Effective level: supervised (header: supervised, cap: bug → supervised)
  • Plan: on issue fix: investigate JAX gradient mismatch at parameter 9 #164, written at start and unchanged in scope
  • Gate: tests n/a (workspace has no unit-test directory; exact regression scripts passed) · smoke 52 passed / 0 failed / 3 declared skips · review CLEAN · Heart RED with human-authorized corrective exception for release validation FAILED (stage integrate)
  • Human: plan sound in hindsight?
  • Human: diff matches plan (no scope creep)?
  • Human: merge, amend, or reject — then log the outcome

Generated by the PyAutoLabs agent workflow.

@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label Jul 14, 2026
@Jammy2211 Jammy2211 merged commit 6c4ff26 into main Jul 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant