Skip to content

Install playwright breaking change#72

Merged
rhelmstedter merged 3 commits intomainfrom
install-playwright-breaking-change
Mar 2, 2026
Merged

Install playwright breaking change#72
rhelmstedter merged 3 commits intomainfrom
install-playwright-breaking-change

Conversation

@bbelderbos
Copy link
Collaborator

main:

uv pip install 'install-playwright==1.0.0' && uv run --no-sync eatlocal init

TypeError: 'BrowserType' object is not iterable

fix branch:

uv pip install 'install-playwright==1.0.0' && uv run --no-sync eatlocal init

works

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates eatlocal init to work with install-playwright==1.0.0’s breaking API change (the installer now expects an iterable of browser types rather than a single BrowserType).

Changes:

  • Update install_browser() to pass an iterable ([p.chromium]) into install_playwright.install(...).
  • Bump the install-playwright dependency to >=1.0.0.
  • Regenerate uv.lock to reflect the dependency update (and associated transitive updates).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/eatlocal/eatlocal.py Fixes runtime TypeError by passing an iterable of browser types to install_playwright.install.
pyproject.toml Updates declared dependency constraint for install-playwright to include the breaking-change version.
uv.lock Updates the resolved lockfile to install-playwright==1.0.0 and related dependency resolution changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhelmstedter rhelmstedter merged commit 77d7209 into main Mar 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants