feat: Add a CLI for exercising the asyncio MQTT session #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
previously approved these changes
Jun 30, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
Looks good - nice and simple. I get that the mqtt messages will be improved in the future - so looks good for now.
Contributor
Author
|
This needs another review post merge |
Lash-L
previously approved these changes
Jul 1, 2025
Contributor
Author
|
I had to fix a lint error during merge, then got the commit style wrong so had to force push again. whoops. Please take a look again. |
Lash-L
approved these changes
Jul 1, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
Still looks great, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line that can connect to the MQTT session and subscribe for messages. Right now it just prints a prefix of the bytes stream.
% roborock session Discovered devices: Roborock Downstairs, Roborock Upstairs INFO:roborock.mqtt.roborock_session:Starting MQTT session Starting MQTT session... MQTT session started. Listening for messages... Stopping MQTT session...