Open
Conversation
bojanpy
reviewed
Sep 25, 2019
| help = 'Closes the specified poll for voting' | ||
|
|
||
| # this should be synced with timetable model somehow, not hardcoded | ||
| PRESENTATION_TYPE = { |
Collaborator
There was a problem hiding this comment.
Please Import from pyconbalkan/timetable/models.py:16 instead of redeclaring
bojanpy
reviewed
Sep 26, 2019
pyconbalkan/timetable/models.py
Outdated
| def slugify(self): | ||
| return slugify(self.title) | ||
|
|
||
| @property |
Collaborator
There was a problem hiding this comment.
no, this method should be on the speaker model, not here !
Collaborator
Author
There was a problem hiding this comment.
but you need it as well here, check how url is formed: /speaker/alex-plugaru/#talk-scaling-flask-and-celery
I mean I don't know if we want to use it, but it's here for different purpose.
Collaborator
There was a problem hiding this comment.
so what blocks you from saying session.speaker.slugify, why do you need to call session.slugify_speaker?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SO, this is far from finished, but timetable table needs some love. I will also need to implement buttons to show hide days, because by default all of them are shown :)
It would be great to make event titles more visible and table as whole more beautiful and similar in style as the rest of the website. I will add buttons and functionality to show/hide events tonight.