fix: clear the terminal before the install intro animation - #10
Conversation
The intro absolute-positions the logo grid and progress bar to fixed screen rows, which assumes a clean screen. With prior shell output the frames interleave with old text. Clear the screen at animation start in both install.sh and install.ps1; the non-animated path is unchanged.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe installers now use the ChangesInstaller and OAuth updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/oauth/src/oauth-pages.ts`:
- Around line 91-97: Update the `.status` style in the OAuth page CSS to remove
`white-space: nowrap`, `overflow: hidden`, and `text-overflow: ellipsis`,
allowing the status text to wrap normally on narrow screens while preserving the
remaining layout and typography styles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06f21afb-306d-4f8e-89fa-2494d54c2d58
📒 Files selected for processing (5)
.changeset/install-clear-screen.md.changeset/oauth-pages-light-redesign.mdapps/pythinker-web/public/install.ps1apps/pythinker-web/public/install.shpackages/oauth/src/oauth-pages.ts
commit: |
The pythinker.com/install.{sh,ps1} URLs serve a stale bootstrap from an
older installer flow, so the update notice and docs pointed users at a
script that cannot find current release assets. Use the CDN-hosted
scripts under code.pythinker.com/pythinker-code/ everywhere.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @pythoughts/pythinker-code@0.6.2 ### Patch Changes - [#10](#10) [`ad2391b`](ad2391b) - Clear the terminal before the install script's animated intro so earlier shell output no longer interleaves with the logo animation. - [#10](#10) [`ad2391b`](ad2391b) - Restyle the browser OAuth sign-in confirmation pages for all providers to match the website's light design. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Related Issue
No linked issue — problem explained below.
Problem
The install scripts' animated intro draws the logo grid and progress bar at fixed screen rows (5-9 and 17). When the terminal already has output (e.g. after an apt run), the animation interleaves with the existing text and renders garbled.
What changed
Both
install.shandinstall.ps1clear the screen and home the cursor when the animated intro starts. The non-animated path (CI,NO_COLOR, redirected output) is unchanged, so logs and pipes are unaffected.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Summary by CodeRabbit
New Features
Bug Fixes