Skip to content

fix: clear the terminal before the install intro animation - #10

Merged
elkaix merged 5 commits into
mainfrom
fix/install-clear-screen
Aug 4, 2026
Merged

fix: clear the terminal before the install intro animation#10
elkaix merged 5 commits into
mainfrom
fix/install-clear-screen

Conversation

@elkaix

@elkaix elkaix commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Related Issue

No linked issue — problem explained below.

Problem

The install scripts' animated intro draws the logo grid and progress bar at fixed screen rows (5-9 and 17). When the terminal already has output (e.g. after an apt run), the animation interleaves with the existing text and renders garbled.

What changed

Both install.sh and install.ps1 clear the screen and home the cursor when the animated intro starts. The non-animated path (CI, NO_COLOR, redirected output) is unchanged, so logs and pipes are unaffected.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

Summary by CodeRabbit

  • New Features

    • Redesigned browser OAuth confirmation pages with a lighter, grid-based layout, improved spacing, typography, and responsive animations.
    • Added animated success and error indicators with clearer status messaging.
  • Bug Fixes

    • Installation scripts now clear the terminal and reset the cursor before displaying their animated introductions.
    • Updated installation instructions and commands to use the current code hosting URLs across supported platforms.

elkaix added 2 commits August 3, 2026 23:13
The intro absolute-positions the logo grid and progress bar to fixed
screen rows, which assumes a clean screen. With prior shell output the
frames interleave with old text. Clear the screen at animation start in
both install.sh and install.ps1; the non-animated path is unchanged.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b5535608-acf6-4621-97d2-0fe9c245c1d3

📥 Commits

Reviewing files that changed from the base of the PR and between 0e07fb3 and cdbda36.

📒 Files selected for processing (5)
  • apps/pythinker-code/src/constant/app.ts
  • apps/pythinker-code/test/cli/update/preflight.test.ts
  • apps/pythinker-web/public/install.ps1
  • apps/pythinker-web/public/install.sh
  • packages/oauth/src/oauth-pages.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/oauth/src/oauth-pages.ts
  • apps/pythinker-web/public/install.sh

📝 Walkthrough

Walkthrough

The installers now use the code.pythinker.com/pythinker-code endpoints and clear the terminal before animated output. OAuth callback pages now use a light design and display status text. Two patch changesets document these updates.

Changes

Installer and OAuth updates

Layer / File(s) Summary
Installer endpoint and terminal updates
apps/pythinker-code/src/constant/app.ts, apps/pythinker-code/test/cli/update/preflight.test.ts, apps/pythinker-web/public/install.*, .changeset/install-clear-screen.md
Installer URL constants, documentation, fallback commands, and test expectations use the new hosted endpoints. Shell and PowerShell animations clear the terminal and reset the cursor.
OAuth callback page redesign
packages/oauth/src/oauth-pages.ts, .changeset/oauth-pages-light-redesign.md
OAuth pages use a light grid-backed card layout with updated badges, typography, spacing, shadows, and reduced-motion rules. The renderer requires and displays statusLine for provider-specific success and error states.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required fix prefix, stays within 72 characters, uses imperative wording, and describes the main installer animation change.
Description check ✅ Passed The description includes all required sections, explains the problem and changes, and completes the checklist with the related issue exception documented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/oauth/src/oauth-pages.ts`:
- Around line 91-97: Update the `.status` style in the OAuth page CSS to remove
`white-space: nowrap`, `overflow: hidden`, and `text-overflow: ellipsis`,
allowing the status text to wrap normally on narrow screens while preserving the
remaining layout and typography styles.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 06f21afb-306d-4f8e-89fa-2494d54c2d58

📥 Commits

Reviewing files that changed from the base of the PR and between 564c41e and 0e07fb3.

📒 Files selected for processing (5)
  • .changeset/install-clear-screen.md
  • .changeset/oauth-pages-light-redesign.md
  • apps/pythinker-web/public/install.ps1
  • apps/pythinker-web/public/install.sh
  • packages/oauth/src/oauth-pages.ts

Comment thread packages/oauth/src/oauth-pages.ts
@pkg-pr-new

pkg-pr-new Bot commented Aug 4, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@pythoughts/pythinker-code@cdbda36
npx https://pkg.pr.new/@pythoughts/pythinker-code@cdbda36

commit: cdbda36

elkaix added 2 commits August 3, 2026 23:22
The pythinker.com/install.{sh,ps1} URLs serve a stale bootstrap from an
older installer flow, so the update notice and docs pointed users at a
script that cannot find current release assets. Use the CDN-hosted
scripts under code.pythinker.com/pythinker-code/ everywhere.
@elkaix
elkaix merged commit ad2391b into main Aug 4, 2026
12 checks passed
@elkaix
elkaix deleted the fix/install-clear-screen branch August 4, 2026 03:28
elkaix pushed a commit that referenced this pull request Aug 4, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @pythoughts/pythinker-code@0.6.2

### Patch Changes

- [#10](#10)
[`ad2391b`](ad2391b)
- Clear the terminal before the install script's animated intro so
earlier shell output no longer interleaves with the logo animation.

- [#10](#10)
[`ad2391b`](ad2391b)
- Restyle the browser OAuth sign-in confirmation pages for all providers
to match the website's light design.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant