[Stable] Pin networkx in constraints#3331
Merged
Merged
Conversation
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15 (cherry picked from commit 38b03f4)
kdk
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the recent release of networkx 2.4 several deprecated APIs were
removed. This broke the visualization dependency nxpd. A fix is in
progress [1] to address this. But in the meantime to get tests working
again we need to make sure we do not install networkx 2.4 for testing.
This commit does this by pinning the version we use in our testing in
the constraints file to 2.3. This will unblock our development while we
wait for a new nxpd release.
(cherry picked from commit 38b03f4)
Details and comments
[1] chebee7i/nxpd#15
Backported from #3276