Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
Fixed a bug in `~rustworkx.PyDiGraph.find_successor_node_by_edge` where
the method always returned the source node by mistake. Now, it returns
any of the successors, as originally intended.
2 changes: 1 addition & 1 deletion src/digraph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2359,7 +2359,7 @@ impl PyDiGraph {
let edge_predicate_raw = predicate_callable(edge.weight())?;
let edge_predicate: bool = edge_predicate_raw.extract(py)?;
if edge_predicate {
return Ok(self.graph.node_weight(edge.source()).unwrap());
return Ok(self.graph.node_weight(edge.target()).unwrap());
}
}
Err(NoSuitableNeighbors::new_err("No suitable neighbor"))
Expand Down
2 changes: 1 addition & 1 deletion tests/digraph/test_edges.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def compare_edges(edge):
return "b to c" == edge

res = dag.find_successor_node_by_edge(node_b, compare_edges)
self.assertEqual("b", res)
self.assertEqual("c", res)

def test_find_successor_node_by_edge_no_match(self):
dag = rustworkx.PyDiGraph()
Expand Down