Split hashbrown dependency between Python-space and rustworkx-core#1552
Merged
IvanIsCoding merged 1 commit intoQiskit:mainfrom Feb 16, 2026
Merged
Split hashbrown dependency between Python-space and rustworkx-core#1552IvanIsCoding merged 1 commit intoQiskit:mainfrom
hashbrown dependency between Python-space and rustworkx-core#1552IvanIsCoding merged 1 commit intoQiskit:mainfrom
Conversation
`rustworkx-core` exposes `hashbrown` types in its own public API, which requires downstream crates match their resolved `hashbrown` versions to the one used by `rustworkx-core` in its API (up to potentially using a re-export of `hashbrown` from `rustworkx-core`, but one isn't provided, and it's not really scalable for `rustworkx-core` to claim it dictates the version of such a commonly used package). The Python-space `rustworkx` package passes `hashbrown` types between PyO3 and `petgraph` interfaces, so requires hard matches to the resolved versions used by those libraries, but that's a tighter constraint. These separate concerns motivate splitting the allowed bounds on `hashbrown`, so that downstream Rust-space consumers of `rustworkx-core` can use newer versions of `hashbrown` without being held back by the Python-space package. For example, with this commit, Qiskit can now upgrade its internal use to `hashbrown 0.16.1`, including extracting those objects from (a newer) PyO3 and passing them to `rustworkx-core`.
4 tasks
Member
Author
|
Just to draw attention to it: I've not modified the lockfile in this PR (and |
Collaborator
|
I will take a look at this shortly |
Pull Request Test Coverage Report for Build 22074012743Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustworkx-coreexposeshashbrowntypes in its own public API, which requires downstream crates match their resolvedhashbrownversions to the one used byrustworkx-corein its API (up to potentially using a re-export ofhashbrownfromrustworkx-core, but one isn't provided, and it's not really scalable forrustworkx-coreto claim it dictates the version of such a commonly used package).The Python-space
rustworkxpackage passeshashbrowntypes between PyO3 andpetgraphinterfaces, so requires hard matches to the resolved versions used by those libraries, but that's a tighter constraint.These separate concerns motivate splitting the allowed bounds on
hashbrown, so that downstream Rust-space consumers ofrustworkx-corecan use newer versions ofhashbrownwithout being held back by the Python-space package. For example, with this commit, Qiskit can now upgrade its internal use tohashbrown 0.16.1, including extracting those objects from (a newer) PyO3 and passing them torustworkx-core.