Bump pyo3 and rust numpy version to 0.19.0#887
Merged
IvanIsCoding merged 4 commits intoQiskit:mainfrom Jun 1, 2023
Merged
Conversation
Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit updates the version used in rustworkx to these latest releases. At the same time this updates usage of text signature for classes that was deprecated in 0.19.0 release. While not fatal for normal builds this would have failed clippy in CI because we treat warnings as errors.
Pull Request Test Coverage Report for Build 5144317507
💛 - Coveralls |
Collaborator
|
Oh wow my stubs test is failing. Probably if you put |
Collaborator
|
I ran it locally and I can confirm that changing https://github.com/Qiskit/rustworkx/blob/main/rustworkx/iterators.pyi#L71 to |
Member
Author
|
It must be caused by an upstream change in rust-numpy (or something around that). I'll edit the stub file, as I think it'd be good to try and get this in for 0.13.0 which besides #823 I think is ready. |
IvanIsCoding
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit updates the version used in rustworkx to these latest releases. At the same time this updates usage of text signature for classes that was deprecated in 0.19.0 release. While not fatal for normal builds this would have failed clippy in CI because we treat warnings as errors.