fix(reports): bind copied fixes to findings and route manual fixes without callbacks - #39
Open
sxyseo wants to merge 4 commits into
Open
fix(reports): bind copied fixes to findings and route manual fixes without callbacks#39sxyseo wants to merge 4 commits into
sxyseo wants to merge 4 commits into
Conversation
Append renderer-owned callback metadata to copied HTML fix actions while leaving persisted findings and Markdown unchanged. Implements docs/specs/2026-07-30-html-finding-fix-callback.md and was validated with the HTML interaction and report-render tests plus npm test.
Add an explicit manual direct-fix route while preserving strict finding-bound callbacks and ordinary review behavior. Implements docs/specs/2026-07-30-manual-direct-fix-routing.md and was validated with fresh-context routing checks, documentation-link tests, package verification, and npm test.
Keep legacy renderer callers working by emitting an empty action payload when no final findings path is available, while preserving exact callback validation whenever action context is provided. Align docs/specs/2026-07-30-html-finding-fix-callback.md with the compatibility boundary and validate it with focused HTML tests, the doc-link graph, package verification, and the full suite apart from local Windows symlink-permission failures. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
Keep the manual direct-fix route intact while fitting the root Skill below its enforced 220-line prompt budget. This follows docs/specs/2026-07-30-manual-direct-fix-routing.md and was validated with the focused Skill test and documentation-link checks. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-up fixes building on the merged Codex HTML report actions (PR #8):
Changes
scripts/harness-analysis/render-report.mjs,renderers/html.mjs,renderers/html-interactions.mjs: associate copied fixes with findings.skills/better-harness/SKILL.md,references/manual-direct-fix.md: document and route manual direct fixes without callbacks.templates/reporting/html-visual.md,docs/better-harness-doc-links.mmd: update report guidance and the documentation link graph.docs/specs/2026-07-30-html-finding-fix-callback.md,docs/specs/2026-07-30-manual-direct-fix-routing.md.test/html-report-interactions.test.mjs,test/harness-report-render-cli.test.mjs,test/better-harness-skill.test.mjs.Test plan
node --test test/html-report-interactions.test.mjs test/harness-report-render-cli.test.mjs test/better-harness-skill.test.mjsnode --test test/doc-link-graph.test.mjsnpm testnpm run pack:verifyRebased onto latest
upstream/main.