Skip to content

fix(adapters): keep host capability claims aligned - #5

Closed
theRealBurgerKing wants to merge 2 commits into
QoderAI:mainfrom
theRealBurgerKing:fix/host-capability-consistency
Closed

fix(adapters): keep host capability claims aligned#5
theRealBurgerKing wants to merge 2 commits into
QoderAI:mainfrom
theRealBurgerKing:fix/host-capability-consistency

Conversation

@theRealBurgerKing

Copy link
Copy Markdown

Summary

Add a checked-in host capability declaration and verify it against the existing
configured-asset inventory, session-evidence, and report-platform owners.

Update the adapter matrix and Roadmap to reflect implemented Claude Code and
Cursor paths without changing host runtime behavior.

Why

  • Issue/Story: None. Issue creation is restricted in this repository; this is justified maintenance to reconcile public capability claims with existing implementation.
  • User or maintainer outcome: Contributors and users can distinguish implemented host paths from per-workspace evidence availability and real-host smoke coverage.

Traceability and Scope

  • Spec/ADR, if applicable: docs/specs/2026-07-28-host-capability-consistency.md
  • Acceptance criteria addressed: AC-1 through AC-4
  • Canonical owners changed: docs/adapters/, roadmap.md, scripts/harness-analysis/report-run.mjs, and focused consistency tests
  • Explicit non-goals: No new host, session source, inventory collector, checkup behavior, packaging behavior, home-directory access, or host-runtime behavior.

Change Type

  • Feature
  • Bug fix
  • Tests only
  • Documentation/community
  • Refactor with no intended behavior change
  • Dependency, packaging, or infrastructure

Test and Review Evidence

Check Result
node --test test/host-capability-consistency.test.mjs test/agent-customize-architecture.test.mjs test/harness-report-run.test.mjs test/session-analysis-providers.test.mjs Passed: 30/30
node scripts/doc-link-graph/cli.mjs skills/better-harness Passed: graph remains 34 files and 50 links
node --test test/doc-link-graph.test.mjs Passed: 6/6
git diff --check Passed
npm test Ran, but did not pass in this local environment: Node v26.5.0 is outside the declared Node 22–24 range; locked WASM runtime dependencies were unavailable and preview tests could not bind loopback. Focused checks above passed.

Manual or visual evidence:

  • Reviewed every declared yes state against its existing inventory, session, or report implementation owner.
  • Confirmed no host runtime or private-data collection path changed.

Risk and Recovery

  • Compatibility and cross-platform impact: Data-only declaration and Node test; no shell-specific behavior added.
  • Package, plugin, schema, or generated-file impact: Adds a shipped documentation JSON declaration; no package or plugin behavior changes.
  • Rollback or recovery path: Revert this single commit.
  • Residual risk or unverified boundary: No installed-host smoke was run. The declaration intentionally does not claim real-host smoke coverage.

AI Involvement

  • Level: Assisted
  • Human review and validation: Reviewed capability claims, diff scope, focused test output, documentation graph output, and full-suite failure boundaries.

Checklist

  • I followed AGENTS.md, CONTRIBUTING.md, and the relevant canonical-owner guidance.
  • The change is focused and does not include unrelated local or generated state.
  • Tests and documentation match the behavior actually delivered.
  • Markdown links were checked when documentation moved or changed.
  • Cross-platform behavior was considered for Windows, macOS, and Linux.
  • Package/runtime verification was run when shipped files or dependencies changed.
  • User-facing or compatibility changes are recorded in CHANGELOG.md.
  • I have the right to contribute this work under the repository's MIT License.

Add a checked-in host capability declaration and test it against the existing inventory, session, and report owners. Update the adapter matrix and Roadmap to reflect the implemented Claude and Cursor paths without changing host runtime behavior.

Implements docs/specs/2026-07-28-host-capability-consistency.md. Focused capability and documentation checks passed; the full suite remains blocked by the local unsupported Node runtime, missing locked WASM dependencies, and loopback restrictions.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 通过引入一个“可机读的主机能力声明(capabilities.json)”与一致性测试,用来校准对外文档(适配器矩阵与 Roadmap)中关于各 host(qoder/codex/claude/cursor)能力支持情况的表述,使其与现有实现所有者保持一致,并避免改变任何 host 运行时行为。

Changes:

  • 新增 docs/adapters/capabilities.json 作为能力声明(固定 schema/vocabulary/hosts/capabilities)。
  • 新增一致性测试:校验声明中的 yes 状态分别在 inventory provider、session analyzer、report platform 中存在实现所有者,并校验文档引用与 Roadmap 表格行内容。
  • 更新 roadmap.mddocs/adapters/README.md,使其指向该声明并修正文档中的能力表述;同时将 reportPlatform 导出以便被测试复用。

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/host-capability-consistency.test.mjs 新增一致性测试,校验声明/实现所有者/文档与 Roadmap 同步
scripts/harness-analysis/report-run.mjs 导出 reportPlatform,用于一致性测试验证平台接受列表
roadmap.md 更新能力矩阵与摘要、标记相关 TODO 为完成
docs/specs/2026-07-28-host-capability-consistency.md 增加规格说明,覆盖 AC-1~AC-4 与证据
docs/adapters/README.md 增加对能力声明的引用与边界说明
docs/adapters/capabilities.json 新增机器可读能力声明(schemaVersion=1)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread roadmap.md
Update the Cursor and Claude Roadmap decisions to distinguish implemented local session coverage from the unresolved stable-source question. Add a regression assertion and update docs/specs/2026-07-28-host-capability-consistency.md.

Validated with node --test test/host-capability-consistency.test.mjs, node scripts/doc-link-graph/cli.mjs skills/better-harness, and node --test test/doc-link-graph.test.mjs.
@phodal

phodal commented Jul 31, 2026

Copy link
Copy Markdown
Member

Thanks for the careful writeup — the PR body, spec, and evidence table are exemplary. Unfortunately main has moved past this change since it was opened, so we're closing it rather than asking for a rebase:

  • roadmap.md was fully rewritten as the loop control-plane roadmap (973751e); the host x capability matrix, the A/C/U/L task table, and the Open Decisions rows this PR edits no longer exist. The new test's exact-string assertions against those rows would fail after a rebase.
  • Support-declaration consistency already landed on main via test/support-declarations.test.mjs (0750bc8, roadmap A-06), covering 8 platforms (qoder, codex, claude, cursor, qwen, copilot, pi, workbuddy) across CLI help, provider registry, session platforms, report platforms, and docs. A capabilities.json pinned to exactly 4 hosts would contradict that.
  • The stale adapter-doc claims this PR targets have since been corrected on main (e.g. the Claude session adapter is documented in docs/adapters/README.md).

If you'd like to carry the machine-readable capability-declaration idea forward, a fresh PR that folds it into support-declarations.test.mjs as the single declaration source — covering all current hosts, with two-way consistency checks and no prose-row regex assertions — would be welcome.

@phodal phodal closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants