[WIP] Temperature gravity general#27
Open
smaffei wants to merge 13 commits into
Open
Conversation
… the python implicit model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Work in progress **
(creating pull request because Philippe told me it makes getting feedback easier)
Implements general gravity and temperature profiles. Also introduces fixed-flux boundary conditions (currently only in the linear calculations, not sure yet if this needs to be done in the non-linear model) and fixes the Pr number dependency (linear calculations).
This version has been tested with various temperature profiles, different Pr and different E numbers against published results and against MagIC, so I feel fairly confident about what I am doing so far.
Before closing the book on the linear model, and moving onto the non-linear model (which is partially implemented, but not thoroughly tested), I need to check the general gravity profile