Skip to content

README updates#70

Draft
Shnatsel wants to merge 4 commits intomainfrom
updated-readme
Draft

README updates#70
Shnatsel wants to merge 4 commits intomainfrom
updated-readme

Conversation

@Shnatsel
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (8fe9395) to head (736c212).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   99.78%   99.79%           
=======================================
  Files          13       13           
  Lines        2846     2892   +46     
=======================================
+ Hits         2840     2886   +46     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


## Planned features

- Bluestein's algorithm (to handle arbitrary sized FFTs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep this as it would allow us to allow for non-power-of-2 input sizes.

The fourier crate seems to have a good reference implementation: https://github.com/calebzulawski/fourier/blob/master/fourier-algorithms/src/bluesteins.rs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that non-power-of-2 FFTs have much worse performance, up to 10x, even in RustFFT that has multiple different algorithms to deal with them, including a dedicated path for prime numbers.

zero-padding ought to be much faster despite the extra copy, but if that's not always applicable then yeah I guess we'll need code for arbitrary-sized FFTs too just like RustFFT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants