Conversation
✅ Deploy Preview for majestic-griffin-10b166 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to automatically rebase remaining open translation-sync-* PRs after one such PR is merged, reducing conflict rates in the translation sync process.
Changes:
- Introduces a new
pull_request.closed-triggered workflow gated to mergedtranslation-sync-*PRs. - Runs
quantecon/action-translationinmode: rebaseto regenerate/rebase sibling translation PRs. - Adds a concurrency group to prevent overlapping rebases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rebase-translations workflow
Adds a new workflow that automatically rebases open
translation-sync-*PRs when a sibling translation PR is merged.Why
When multiple upstream PRs modify the same file, the first translation PR to merge makes the others conflict (full-file replacement). This caused a 62% merge conflict rate (issue QuantEcon/action-translation#63).
How it works
When a
translation-sync-*PR is merged:mainWhat's added
.github/workflows/rebase-translations.yml— triggered onpull_request.closedfor translation-sync branchesquantecon/action-translation@v0.15withmode: rebaseSee action-translation v0.15.0 release for full details.