perf(contract_tools): optimize balance fetching by batching Horizon r…#162
Merged
Conversation
Contributor
|
@Nemenwq resolve conflicts. |
Contributor
Author
|
@YaronZaki done. please review |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…equests
Description
Related Issue
closes #60
Change Type
I have optimized the way token balances are fetched from the Stellar network. Previously, the system made sequential HTTP requests for each supported token. Now, it fetches the entire account data in a single call and extracts all relevant balances.
Changes Made
blockchain_call.py
Added
_get_account_data
: A new private helper method that fetches and parses the full account data from the Stellar Horizon API. It handles 404 (account not found) and other network errors gracefully.
Refactored
get_token_balances
: Now calls
_get_account_data
once and iterates through the returned balances to find all supported tokens.
Refactored
fetch_portfolio
: Similar optimization applied to the portfolio fetching logic, ensuring only one network request is made instead of one per token.
Testing Done
Screenshots (if UI changes)
Checklist
poetry run pytest)pylint)