convert(TensorMap, t) retains storagetype
#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkdvos
commented
Jan 22, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
kshyatt
approved these changes
Jan 22, 2026
Member
Author
|
@kshyatt seems like we are hitting segfaults again, any clue what's going on? |
Member
|
I've only ever seen this on CI, sometimes the solution is to retry the build which I have done |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to ensure the storagetype of a tensor is retained when calling
convert(TensorMap, t).Pulled out of #349