Extend dependency checking facilities#473
Conversation
|
Although code review is appreciated, could you please assess sanity of the idea? For now this is my main concern. |
|
We cannot guarantee that the client is 100% certain of the state, the dependencies check on the client is more like a promise. If someone adds a new extension on the server that handles I don't think I have enough knowledge to tell you which way is right. I am not sure. QubesOS/qubes-issues#10860 (comment). |
|
Good point. I also realize that even if the server does the checking there is no mechanism to prevent race conditions between the original client acting on the result and another client changing a dependency. Am I overthinking this? |
Regarding QubesOS/qubes-issues#10860
As far as I can tell #469 fixes it on shutdown by retrying as many times as there are used vms, and it should be faster than
vm_dependencies. I'm not sure how good that approach is from the design perspective considering that it handles all these errors and logs a lot.My idea here is instead set up a facility for checking domain sets and use force on independent sets. I also plan to make
vm_dependenciesmore efficient by creating necessary api for accessing e.g.qubes.vm.mix.net.NetVMMixin.connected_vms, but before any of that or proceeding with integration of this change I would like to show and receive feedback.