Add CI coverage for vmupdate formatting and pylint checks.#215
Conversation
aed978a to
aa2ca20
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 71.72% 71.72%
=======================================
Files 12 12
Lines 1337 1337
=======================================
Hits 959 959
Misses 378 378 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| script: | ||
| - export PATH="$HOME/.local/bin:$PATH" | ||
| - PYTHONPATH=~/core-admin-client ./run-tests.sh | ||
| - python3 -m black -l80 --check setup.py vmupdate |
There was a problem hiding this comment.
We have some template jobs for this already. Try:
include:
- file: /common.yml
project: QubesOS/qubes-continuous-integration
...
lint:
extends: .lint
stage: checks
variables:
DIR: vmupdate
if pylint needs to be custom anyway, you can add SKIP_PYLINT: 1 here and keep pylint as you do now.
There was a problem hiding this comment.
Nice, this is better.
Did as you suggested
aa2ca20 to
3176257
Compare
marmarek
left a comment
There was a problem hiding this comment.
for now lets include it as is; but eventually I'd like to reduce number of disabled pylint checks
|
feel free to ping me anytime on matrix. :) |
|
When not intending to close an issue or pull request. Use "For:" instead of "Fixes:". |
|
Noted, thanks |
This extends the existing GitLab test job so vmupdate changes are checked with black and pylint after the unit tests run.
The patch also formats the current vmupdate files so the new black check starts from a clean baseline, and adds a focused pylint configuration for the checks that are actionable in this tree.
Mypy is intentionally not enabled in this PR because current upstream still has existing typing errors that need a separate cleanup before it can be a blocking CI check.
fixes: #213 (comment)