Skip to content

Skip memory assignment on domain still starting #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Aug 6, 2025
Merged

Skip memory assignment on domain still starting #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion qubes/qmemman/systemstate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,15 @@ def do_balloon_dom(self, dom_memset: dict) -> bool:
for _, dom in dom_dict.items():
dom.no_progress = False

succeeded = []
memset_reqs = {}
for domid, memset in dom_memset.items():
if memset == 0:
# Domain hasn't meminfo back to the server, it is still at the
# initial amount. pref_mem can't be calculated yet.
if dom_dict[domid].mem_used is None:
succeeded.append(domid)
continue
mem_pref = qubes.qmemman.algo.pref_mem(dom_dict[domid])
memset_reqs[domid] = mem_pref
self.log.debug(
Expand All @@ -296,7 +302,6 @@ def do_balloon_dom(self, dom_memset: dict) -> bool:
else:
memset_reqs[domid] = memset

succeeded = []
while True:
self.log.debug("niter={:d}".format(niter))
self.refresh_mem_actual(domid_list)
Expand Down