Skip to content

tests: fix failure handling in test_031_firewall_dynamic_block #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Mar 30, 2026
+4 −2
Merged

tests: fix failure handling in test_031_firewall_dynamic_block #795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions qubes/tests/integ/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,8 @@ def test_031_firewall_dynamic_block(self):
)
)

client1 = None
client2 = None
try:
self.assertEqual(
self.run_cmd(self.testvm1, self.ping_ip), 0, "Ping by IP failed"
Expand Down Expand Up @@ -871,10 +873,10 @@ def test_031_firewall_dynamic_block(self):
if server2.returncode is None:
server2.terminate()
self.loop.run_until_complete(server2.wait())
if client1.returncode is None:
if client1 and client1.returncode is None:
client1.terminate()
self.loop.run_until_complete(client1.wait())
if client2.returncode is None:
if client2 and client2.returncode is None:
client2.terminate()
self.loop.run_until_complete(client2.wait())

Expand Down