Skip to content

Disable notification for denied property.GetAll call #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Jun 26, 2026
+15 −0
Merged

Disable notification for denied property.GetAll call #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ endif
mkdir -p $(DESTDIR)/usr/libexec/qubes
install -m 0644 qubes-rpc-policy/90-default.policy \
$(DESTDIR)/etc/qubes/policy.d/90-default.policy
install -m 0644 qubes-rpc-policy/91-admin-default-deny.policy \
$(DESTDIR)/etc/qubes/policy.d/91-admin-default-deny.policy
install -m 0644 qubes-rpc-policy/85-admin-backup-restore.policy \
$(DESTDIR)/etc/qubes/policy.d/85-admin-backup-restore.policy
cp qubes-rpc/qubes.FeaturesRequest $(DESTDIR)/etc/qubes-rpc/
Expand Down
12 changes: 12 additions & 0 deletions qubes-rpc-policy/91-admin-default-deny.policy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
## Do not modify this file, create a new policy file with a lower number in the
## filename instead. For example `30-user.policy`.

## Default action is deny anyway, but add notify=no, as GetAll is expected to
## be called if some properties are allowed but not all, so mute the spurious
## notification

admin.vm.property.GetAll * @anyvm @anyvm deny notify=no
admin.vm.property.GetAll * @anyvm @adminvm deny notify=no

admin.property.GetAll * @anyvm @anyvm deny notify=no
admin.property.GetAll * @anyvm @adminvm deny notify=no
1 change: 1 addition & 0 deletions rpm_spec/core-dom0.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ done
%attr(0664,root,qubes) %config /etc/qubes/policy.d/85-admin-backup-restore.policy
%attr(0664,root,qubes) %config /etc/qubes/policy.d/90-admin-default.policy
%attr(0664,root,qubes) %config /etc/qubes/policy.d/90-default.policy
%attr(0664,root,qubes) %config /etc/qubes/policy.d/91-admin-default-deny.policy
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-global-ro
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-global-rwx
%attr(0664,root,qubes) %config(noreplace) /etc/qubes/policy.d/include/admin-local-ro
Expand Down