Issue 8878 - Global Config app not closing if Help Window is Open#200
Conversation
|
@alimirjamali: FYI, if you want GitHub to automatically close the associated issue when this PR is merged, you must use instead of in the PR or commit message. The intervening |
You are such a life saver. I was wondering why this does not show up as a linked PR in the Github Issue. And given up last night. |
|
Please reword the commit message QubesOS/qubes-core-agent-linux#505 (comment) |
Done. Thanks |
alimirjamali
changed the title
| self.main_window.hide() | ||
| while Gtk.events_pending(): | ||
| Gtk.main_iteration() | ||
| ''' Then wait for disposable helper threads to finish ''' |
There was a problem hiding this comment.
| ''' Then wait for disposable helper threads to finish ''' | |
| # Then wait for disposable helper threads to finish |
Pylint dislikes this sort of comments - the triple-quotes should only be used for docstrings at the start of the method/class/whatnow, otherwise # should be used. (the same comment applies to the previous comment, it wasn't flagged by pylint because it's at the start of the function, so it thought it was a docstring describing the function.
If you care about backstory for this, it's in https://peps.python.org/pep-0257/ :)
There was a problem hiding this comment.
If you care about backstory for this, it's in https://peps.python.org/pep-0257/ :)
Thank you very much for the link. I will read it. I just changed the comments to start with # and forced pushed the amended commit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 93.25% 93.20% -0.05%
==========================================
Files 57 57
Lines 10594 10600 +6
==========================================
+ Hits 9879 9880 +1
- Misses 715 720 +5 ☔ View full report in Codecov by Sentry. |
marmarta
left a comment
marmarta
left a comment
There was a problem hiding this comment.
Codecov is being silly here, this is good.
5 participants
Fixes QubesOS/qubes-issues#8878
New Global Config app not closing if disposable in which doc link was opened is still running
Solution: hide the main window while waiting for subprocess threads to finish.