Show a "saving changes" dialog when saving changes in global config by marmarta · Pull Request #269 · QubesOS/qubes-desktop-linux-manager

marmarta · 2025-07-11T13:40:07Z

codecov · 2025-07-11T15:03:13Z

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (3a85bee) to head (848a630).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
qubes_config/global_config/global_config.py	89.28%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   92.99%   92.93%   -0.07%     
==========================================
  Files          64       64              
  Lines       13034    13060      +26     
==========================================
+ Hits        12121    12137      +16     
- Misses        913      923      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-07-12T08:02:53Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071515-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_devices
- TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
  AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
system_tests_basic_vm_qrexec_gui_zfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_010_run_xterm (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
- TC_20_NonAudio_whonix-gateway-17-pool: test_011_run_gnome_terminal (skipped + cleanup)
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Notepad' matc...

Failed tests

10 failures

system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_devices
- TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
  AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_basic_vm_qrexec_gui_zfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_010_run_xterm (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
- TC_20_NonAudio_whonix-gateway-17-pool: test_011_run_gnome_terminal (skipped + cleanup)
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Notepad' matc...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Details

Performance Tests

Performance degradation:

7 performance degradations

debian-12-xfce_exec-data-simplex: 72.84 🔺 ( previous job: 65.51, degradation: 111.18%)
debian-12-xfce_exec-data-duplex-root: 86.78 🔺 ( previous job: 70.01, degradation: 123.96%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 14169.00 :small_red_triangle: ( previous job: 17102.00, degradation: 82.85%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 729.00 :small_red_triangle: ( previous job: 1091.00, degradation: 66.82%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 402.00 :small_red_triangle: ( previous job: 1840.00, degradation: 21.85%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6070.00 :small_red_triangle: ( previous job: 8874.00, degradation: 68.40%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3665.00 :small_red_triangle: ( previous job: 4420.00, degradation: 82.92%)

Remaining performance tests:

65 tests

debian-12-xfce_exec: 7.16 🟢 ( previous job: 8.63, improvement: 82.92%)
debian-12-xfce_exec-root: 28.80 🟢 ( previous job: 29.44, improvement: 97.85%)
debian-12-xfce_socket: 7.52 🟢 ( previous job: 8.50, improvement: 88.42%)
debian-12-xfce_socket-root: 8.76 🔺 ( previous job: 8.31, degradation: 105.34%)
debian-12-xfce_exec-data-duplex: 72.81 🟢 ( previous job: 73.55, improvement: 99.00%)
debian-12-xfce_socket-data-duplex: 160.94 🟢 ( previous job: 161.35, improvement: 99.74%)
fedora-42-xfce_exec: 9.04
fedora-42-xfce_exec-root: 58.98
fedora-42-xfce_socket: 9.01
fedora-42-xfce_socket-root: 8.24
fedora-42-xfce_exec-data-simplex: 67.38
fedora-42-xfce_exec-data-duplex: 67.20
fedora-42-xfce_exec-data-duplex-root: 106.78
fedora-42-xfce_socket-data-duplex: 144.91
whonix-gateway-17_exec: 7.19 🟢 ( previous job: 7.34, improvement: 97.96%)
whonix-gateway-17_exec-root: 39.46 🟢 ( previous job: 39.57, improvement: 99.72%)
whonix-gateway-17_socket: 6.83 🟢 ( previous job: 7.85, improvement: 87.01%)
whonix-gateway-17_socket-root: 8.57 🔺 ( previous job: 7.89, degradation: 108.56%)
whonix-gateway-17_exec-data-simplex: 76.58 🟢 ( previous job: 77.76, improvement: 98.48%)
whonix-gateway-17_exec-data-duplex: 77.85 🟢 ( previous job: 78.39, improvement: 99.32%)
whonix-gateway-17_exec-data-duplex-root: 94.90 🔺 ( previous job: 90.74, degradation: 104.58%)
whonix-gateway-17_socket-data-duplex: 170.76 🔺 ( previous job: 161.95, degradation: 105.44%)
whonix-workstation-17_exec: 8.16 🟢 ( previous job: 8.27, improvement: 98.63%)
whonix-workstation-17_exec-root: 54.50 🟢 ( previous job: 57.61, improvement: 94.60%)
whonix-workstation-17_socket: 8.56 🟢 ( previous job: 8.97, improvement: 95.49%)
whonix-workstation-17_socket-root: 8.30 🟢 ( previous job: 9.46, improvement: 87.72%)
whonix-workstation-17_exec-data-simplex: 70.56 🟢 ( previous job: 74.54, improvement: 94.66%)
whonix-workstation-17_exec-data-duplex: 67.70 🟢 ( previous job: 74.84, improvement: 90.46%)
whonix-workstation-17_exec-data-duplex-root: 85.83 🟢 ( previous job: 86.00, improvement: 99.80%)
whonix-workstation-17_socket-data-duplex: 146.28 🟢 ( previous job: 160.20, improvement: 91.31%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 449839.00 :green_circle: ( previous job: 289982.00, improvement: 155.13%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 189667.00 :green_circle: ( previous job: 101988.00, improvement: 185.97%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 133805.00 :green_circle: ( previous job: 14284.00, improvement: 936.75%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 73099.00 :green_circle: ( previous job: 32696.00, improvement: 223.57%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11488.00 :green_circle: ( previous job: 11086.00, improvement: 103.63%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 305707.00 :green_circle: ( previous job: 289182.00, improvement: 105.71%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 141646.00 :green_circle: ( previous job: 122848.00, improvement: 115.30%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 433116.00 :small_red_triangle: ( previous job: 433654.00, degradation: 99.88%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 189024.00 :green_circle: ( previous job: 167872.00, improvement: 112.60%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 101427.00 :small_red_triangle: ( previous job: 108760.00, degradation: 93.26%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7946.00 :green_circle: ( previous job: 6356.00, improvement: 125.02%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 348595.00
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 289182.00
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 313381.00
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 93090.00
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 79126.00
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2904.00
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8481.00
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1459.00
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 373158.00
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 238150.00
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 306421.00
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 99484.00
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 93281.00
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2511.00
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 9089.00
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 744.00
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 394646.00
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 172639.00
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 288228.00
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 104052.00
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 79716.00
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4992.00
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7006.00
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 660.00

marmarta force-pushed the saving_dialog branch 2 times, most recently from db38f06 to 48cfee7 Compare July 11, 2025 14:05

Add cairo-devel dependency to CI

4876fd1

marmarta force-pushed the saving_dialog branch from 48cfee7 to 1482b59 Compare July 11, 2025 14:10

marmarek added the openqa-pending label Jul 11, 2025

Show a "saving changes" dialog when saving changes in global config

848a630

fixes QubesOS/qubes-issues#9926

marmarta force-pushed the saving_dialog branch from 1482b59 to 848a630 Compare July 11, 2025 14:43

This was referenced Jul 12, 2025

Add Arch packaging QubesOS/qubes-core-admin-client#332

Open

Improve device category description QubesOS/qubes-core-admin-client#362

Merged

Cleanup qmemman QubesOS/qubes-core-admin#694

Merged

Add conspicuous EOL indicator for dom0 #261

Merged

marmarek approved these changes Jul 16, 2025

View reviewed changes

marmarek merged commit f7e4238 into QubesOS:main Jul 16, 2025
2 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show a "saving changes" dialog when saving changes in global config#269

Show a "saving changes" dialog when saving changes in global config#269
marmarek merged 2 commits into
QubesOS:mainfrom
marmarta:saving_dialog

marmarta commented Jul 11, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

marmarta commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marmarta commented Jul 11, 2025 •

edited

Loading

codecov Bot commented Jul 11, 2025 •

edited

Loading

qubesos-bot commented Jul 12, 2025 •

edited

Loading