Fix R4.3 release links on download page

[parulin]

Update release notes and schedule links from PR QubesOS/qubes-doc#1504
to the latest branch.

Note: I don't understand the purpose of the "Upgrading to Qubes R4.3" link.

Fixes: QubesOS/qubes-issues#10428

[parulin]

I don't understand why the checks have failed.

[andrewdavidwong]

Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put Closes QubesOS/qubes-issues#XXXX in the body of the PR message (where XXXX is the issue number). Closes is one of several special keywords that GitHub will recognize. If and when the PR is merged, GitHub will automatically close the associated issue.

[ben-grande]

I recommend using a commit title that survives on itself, without requiring to access external resources such as sites. Example:

Fix broken links on download page

Fixes: https://github.com/QubesOS/qubes-issues/issues/10428

[parulin]

Sorry for the mess.

[andrewdavidwong]

Note: I don't understand the purpose of the "Upgrading to Qubes R4.3" link.

I believe it's for current 4.2 users who want to upgrade to 4.3.

Sorry for the mess.

Not at all! Thank you for contributing!

[parulin]

I believe it's for current 4.2 users who want to upgrade to 4.3.

I don't see that link in the list:

• How to verify downloads
• Installation guide
• Release notes
• Release schedule
• All download mirrors

[marmarek]

Interesting, while the yaml page has list of title + URL, the html version (_includes/downloads.html) expects specific titles (more or less making it pointless structure):

          {% for docdata in release.docs %}
            {% assign doc_name = docdata[0] %}
            {% assign doc = docdata[1] %}
            {% if doc_name == "Installation guide" %}
              <li><a href="{{ lang }}{{ doc.url }}" class="black-link" title="Installation guide">{{ doc_name }}</a></li>
            {% endif %}
            {% if doc_name == "Release notes" %}
              <li><a href="{{ lang }}{{ doc.url }}" class="black-link" title="Release notes">{{ doc_name }}</a></li>
            {% endif %}
            {% if doc_name == "Release schedule" %}
              <li><a href="{{ lang }}{{ doc.url }}" class="black-link" title="Release schedule">{{ doc_name }}</a></li>
            {% endif %}
          {% endfor %}

IMO it should just use doc_name, instead of this list of "if"

[parulin]

Thanks for the tip !

[marmarek]

Is this still relevant? 51f9a8f did similar thing
cc @unman

[unman]

That looks like a more general future proof solution.

[parulin]

Should I close this PR?