refactor: remove redundant workout tracking tools#105
Merged
Conversation
- Remove get_exercise_progress and list_recent_workouts tools - Remove unused Pydantic models ExerciseHistoryEntry and WorkoutSummary - Remove storage methods get_exercise_history and get_recent_sessions - Update tool registry and tests to reflect removed features
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the get_exercise_progress and list_recent_workouts tools from the workout service. This includes deleting their corresponding storage methods (get_exercise_history and get_recent_sessions), Pydantic models (WorkoutSessionSummary and ExerciseHistoryEntry), registry entries, and associated unit tests. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
list_recent_workoutsandget_exercise_progresstools and their associated storage methods and models.Why
Following the addition of the new periodized training program tools,
get_training_historyprovides the combined functionality of both removed tools. Reducing redundancy saves registry tokens and prevents agent confusion.How
list_recent_workoutsandget_exercise_progressfromsrc/blacki/workouts/tools.py.WorkoutSessionSummaryandExerciseHistoryEntryPydantic models.get_recent_sessionsandget_exercise_historyfrom SQLite storage.src/blacki/registry.pyto stop registering these tools.Tests
uv run pytest --cov=src(100% coverage)uv run ruff formatanduv run ruff checkuv run mypy .