feature: extrinsic signing - #3
Open
ruseinov wants to merge 3 commits into
Open
Conversation
🤖 Augment PR SummarySummary: Adds development-only Quip extrinsic signing support and related UI safeguards.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| }, [flags.isQr, flags.isLocal, isSubmit, t]); | ||
|
|
||
| const isAutoCapable = senderInfo.signAddress && (queueSize > 1) && isSubmit && !(flags.isHardware || flags.isMultisig || flags.isProxied || flags.isQr || flags.isUnlockable) && !isRenderError; | ||
| const isQuipSigningUnavailable = !!quipSigningError(senderInfo.signAddress); |
There was a problem hiding this comment.
packages/react-signer/src/TxSigned.tsx:461 — A view-only Quip account still satisfies isAutoCapable, so an initial multi-item queue calls _doStart even though the button is disabled below; extractParams then throws before the queue status is updated, leaving that item pending instead of reporting the unavailable signing key.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.