Move _select encoding and decoding to threads.#33
Closed
noamraph wants to merge 1 commit intoQuisApp:masterfrom
Closed
Move _select encoding and decoding to threads.#33noamraph wants to merge 1 commit intoQuisApp:masterfrom
noamraph wants to merge 1 commit intoQuisApp:masterfrom
Conversation
|
Hi, I know this PR is old, but it could help the Android performance a lot for devices which have many contacts. |
Contributor
|
Important Notice: Repository Reset for v2.0 This repository is being reset for a complete v2.0 rewrite of flutter_contacts. The existing v1 codebase and full git history will be preserved in the What this means for your PR:
Note that v2 is a complete rewrite with many new features including full macOS support, comprehensive vCard import/export, SIM contacts, contact groups, account management, blocked numbers, ringtone assignment, and more. This PR may already be addressed in v2. Thank you for your contribution, and apologies for the inconvenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes 3 separate changes:
There is still non-responsiveness. I think it's shorter.
The change in FlutterContactsPlugin.kt is reasonable - it just follows the implementation of MethodCallHandler, which is pretty small.
The change in flutter_contacts.dart is pretty ugly. I'm really not sure it's worth it.
The change in example/main.dart was useful because it allowed me to start profiling and then press the button.
I send this mostly as reference. If I were the maintainer, I would see how much the change in FlutterContactsPlugin.kt shortens the non-responsive time, and decide if it's worth the (not too big) added complexity. I would not merge the change in flutter_contacts.dart.
I hope this helps,
Noam