pipe subprocess logging to std out and std err#36
Open
touchaponk wants to merge 1 commit intoQuixiAI:mainfrom
Open
pipe subprocess logging to std out and std err#36touchaponk wants to merge 1 commit intoQuixiAI:mainfrom
touchaponk wants to merge 1 commit intoQuixiAI:mainfrom
Conversation
Author
|
@ehartford could you please see if we can merge the PR since right now longer mcp server response will hang up the client |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces logging for the subprocess's standard output (
stdout) and standard error (stderr) streams`. The changes ensure that output from the subprocess is captured and displayed in the current process's logs for better debugging and monitoring.Enhancements to subprocess logging:
_print_stdoutto read and log lines from the subprocess'sstdoutstream, throttling the loop to prevent excessive CPU usage._print_stderrto read and log lines from the subprocess'sstderrstream, similarly throttling the loop for efficiency.