non-localhost ollama server fix- get ollama host from base_url

[infectedresearch]

Suspect someone's API changed- ollama? httpx? Anyway this works :)

Summary by CodeRabbit

• Refactor
  • Updated the method for determining the host URL used for Ollama API calls, improving compatibility with different client configurations. No changes to user-facing features.

[coderabbitai]

Walkthrough

The update changes the way the Ollama API host URL is determined within the call_ollama_api function. Instead of using the host attribute from the client object, the function now retrieves the host URL from the base_url attribute of the client._client sub-object, if present.

Changes

File	Change Summary
src/dolphin_mcp/providers/ollama.py	Modified logic for selecting the Ollama API host URL in one function

Poem

A rabbit hopped to Ollama’s den,
Seeking the host once again.
No longer just “host” in the client’s hand,
But “_client.base_url” throughout the land!
With URLs found in deeper nests,
Our code now hops with subtle finesse.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7413ed4 and 978517d.

📒 Files selected for processing (1)

• src/dolphin_mcp/providers/ollama.py (1 hunks)

🔇 Additional comments (1)

src/dolphin_mcp/providers/ollama.py (1)

523-524: Avoid relying on a private _client attribute for host extraction

Accessing client._client.base_url couples us to an internal implementation that may change without warning. Instead, try using any public host attribute first, then fall back to the HTTPX base_url, and ensure you still default to DEFAULT_API_HOST. For example, in src/dolphin_mcp/providers/ollama.py around lines 523–524:

-    host = DEFAULT_API_HOST
-    if client and hasattr(client._client, 'base_url'):
-        host = client._client.base_url
+    host = DEFAULT_API_HOST
+    if client:
+        try:
+            # Prefer a public attribute if the SDK still exposes it
+            host = getattr(client, 'host', None) or host
+            # Fallback to HTTPX base_url for newer SDK versions
+            if hasattr(client, '_client'):
+                host = getattr(client._client, 'base_url', host)
+        except Exception as e:
+            logger.warning(f"Could not extract Ollama host ({e}), using default")

• Verify that both older and newer Ollama SDK versions expose either client.host or client._client.base_url as expected.
• Add or update tests to confirm correct URL resolution across versions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.