feat: add prompt for update behavior - #5
Draft
userquin wants to merge 5 commits into
Draft
Conversation
Deploying with
|
| Latest commit: |
b0468dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68a700b1.pwa-a3b.pages.dev |
| Branch Preview URL: | https://userquin-feat-add-prompt-for.pwa-a3b.pages.dev |
userquin
commented
Jan 16, 2024
userquin
commented
Jan 16, 2024
userquin
commented
Jan 17, 2024
| const match = url.match(matcher); | ||
| // use null revision, removing the revision or using undefined will cause workbox warnings in runtime | ||
| return match ? { url, revision: null } : { url, revision: hash }; | ||
| return buildMap.has(url) |
Collaborator
Author
There was a problem hiding this comment.
We should provide sw precaching manifest at build time, we don't need this logic at runtime (in client plugin we have all the required data to do it).
We also need to check why nr build + nr serve or nr build-prompt + nr serve are different from nr preview or nr preview-prompt (build command and/or serve is about SSG (??)?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now I haven't found a way to provide the reload function to the app, just a few days using qwik, provided via
window.loadNewVersion.@Aslemammad no idea why the layout is broken adding the PWAPrompt component in the layout, there is a weird overflow hidden in the main/body.