Skip to content

Fix workflow: secrets context not allowed in if conditions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix workflow: secrets context not allowed in if conditions #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9685550
Initial plan
Copilot Jan 13, 2026
f032a02
Fix workflow syntax: use env vars instead of secrets in if conditions
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions .github/workflows/build-apk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,24 +62,28 @@ jobs:
continue-on-error: true

- name: Setup signing keystore
if: ${{ secrets.KEYSTORE_BASE64 != '' }}
env:
KEYSTORE_BASE64: ${{ secrets.KEYSTORE_BASE64 }}
KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
run: |
# Decode keystore from secret (persistent key for consistent signatures)
echo "${{ secrets.KEYSTORE_BASE64 }}" | base64 -d > android/app/upload-keystore.jks

# Create key.properties file
cat > android/key.properties << EOF
storePassword=${{ secrets.KEYSTORE_PASSWORD }}
keyPassword=${{ secrets.KEY_PASSWORD }}
keyAlias=${{ secrets.KEY_ALIAS }}
if [ -n "$KEYSTORE_BASE64" ]; then
echo "Setting up signing keystore..."
# Decode keystore from secret (persistent key for consistent signatures)
echo "$KEYSTORE_BASE64" | base64 -d > android/app/upload-keystore.jks

# Create key.properties file
cat > android/key.properties << EOF
storePassword=$KEYSTORE_PASSWORD
keyPassword=$KEY_PASSWORD
keyAlias=$KEY_ALIAS
storeFile=upload-keystore.jks
EOF

- name: Note about signing
if: ${{ secrets.KEYSTORE_BASE64 == '' }}
run: |
echo "⚠️ No signing keystore configured - APK will be signed with debug key"
echo "This is normal for forks. The APK will still work for testing."
else
echo "⚠️ No signing keystore configured - APK will be signed with debug key"
echo "This is normal for forks. The APK will still work for testing."
fi

- name: Build APK
run: |
Expand Down
Loading