Skip to content

Filter Intraday Heart Rate data by request date range #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvannierop wants to merge 2 commits into from
+24 −7
Closed

Filter Intraday Heart Rate data by request date range #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465cad7
conservative: filter observation outside of date range
pvannierop Mar 25, 2026
9002239
conservative: download intraday heart rate data by day
pvannierop Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ava/org/radarbase/connect/rest/fitbit/converter/FitbitIntradayHeartRateAvroConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,18 @@ protected Stream<TopicData> processRecords(

// Used as the date to convert the local times in the dataset to absolute times.
ZonedDateTime startDate = request.getDateRange().start();
Instant rangeStart = startDate.toInstant();
Instant rangeEnd = request.getDateRange().end().toInstant();

return iterableToStream(dataset)
.map(tryOrNull(activity -> {
Instant time = startDate.with(LocalTime.parse(activity.get("time").asText()))
.toInstant();

if (time.isBefore(rangeStart) || !time.isBefore(rangeEnd)) {
return null;
}

FitbitIntradayHeartRate heartRate = new FitbitIntradayHeartRate(
time.toEpochMilli() / 1000d,
timeReceived,
Expand Down
25 changes: 18 additions & 7 deletions ...e/src/main/java/org/radarbase/connect/rest/fitbit/route/FitbitIntradayHeartRateRoute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,20 @@

package org.radarbase.connect.rest.fitbit.route;

import static java.time.format.DateTimeFormatter.ISO_LOCAL_TIME;
import static java.time.temporal.ChronoUnit.SECONDS;
import static java.time.ZoneOffset.UTC;

import io.confluent.connect.avro.AvroData;

import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.List;
import java.util.stream.Stream;
import org.radarbase.connect.rest.fitbit.converter.FitbitIntradayHeartRateAvroConverter;
import org.radarbase.connect.rest.fitbit.request.FitbitRequestGenerator;
import org.radarbase.connect.rest.fitbit.request.FitbitRestRequest;
import org.radarbase.connect.rest.fitbit.user.User;
import org.radarbase.connect.rest.fitbit.user.UserRepository;
import org.radarbase.connect.rest.fitbit.util.DateRange;

public class FitbitIntradayHeartRateRoute extends FitbitPollingRoute {
private final FitbitIntradayHeartRateAvroConverter converter;
Expand All @@ -39,15 +43,22 @@ public FitbitIntradayHeartRateRoute(FitbitRequestGenerator generator,

@Override
protected String getUrlFormat(String baseUrl) {
return baseUrl + "/1/user/%s/activities/heart/date/%s/1d/1sec/time/%s/%s.json?timezone=UTC";
// URL format args: user-id, date
return baseUrl + "/1/user/%s/activities/heart/date/%s/1d/1sec.json?timezone=UTC";
}

protected Stream<FitbitRestRequest> createRequests(User user) {
return startDateGenerator(getOffset(user).plus(ONE_SECOND).truncatedTo(SECONDS))
// Important: heart rate is queried at the resolution of a single
// day, so the offset for the next request will be set to the next day.
Instant startDate = this.getOffset(user).plus(ONE_DAY)
.atZone(UTC)
.truncatedTo(ChronoUnit.DAYS).toInstant();
List<DateRange> dateRangeStream = startDateGenerator(startDate).toList();
return dateRangeStream.stream()
.map(dateRange -> newRequest(user, dateRange,
user.getExternalUserId(), DATE_FORMAT.format(dateRange.start()),
ISO_LOCAL_TIME.format(dateRange.start()),
ISO_LOCAL_TIME.format(dateRange.end().truncatedTo(SECONDS))));
user.getExternalUserId(),
DATE_FORMAT.format(dateRange.start())
));
}

@Override
Expand Down
Loading