Conversation
- Need to import everything again - Look how to use vars
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e3ec8b6b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this again thoroughly |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 109897020d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this PR entirely, want to merge this! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d20db0318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gnumake | ||
| ] | ||
| # TODO: wtf? | ||
| ++ lib.optionals (!config.hostConfig.roles.desktop) [ |
There was a problem hiding this comment.
lib in env module arguments
modules/nixos/system/env.nix now calls lib.optionals but the module function no longer accepts lib in its argument set. This makes evaluation fail with an undefined variable error as soon as this module is loaded, so nixosSystem builds cannot proceed for any host using the new module tree.
Useful? React with 👍 / 👎.
| YAMLS=$(find "$BASE_PATH" -name '*.yaml' | awk -F/ '{ print $NF }') | ||
| KUBECONFIG=$(fzf <<<"$YAMLS") | ||
| export KUBECONFIG=$BASE_PATH/$KUBECONFIG | ||
| printf 'export KUBECONFIG=%q\n' "$BASE_PATH/$KUBECONFIG" |
There was a problem hiding this comment.
The new selc_ script prints export KUBECONFIG=... instead of setting it, but zsh alias selc still uses source selc_; sourcing a script that only prints text does not update the shell environment. As a result, running selc no longer changes KUBECONFIG, breaking kubeconfig switching in interactive shells.
Useful? React with 👍 / 👎.
1 participant
Entire restructure