Skip to content

fix(ci): run CI on pull requests#21

Closed
TWal wants to merge 1 commit intomainfrom
twal/ci_on_pull_request
Closed

fix(ci): run CI on pull requests#21
TWal wants to merge 1 commit intomainfrom
twal/ci_on_pull_request

Conversation

@TWal
Copy link
Contributor

@TWal TWal commented Jun 13, 2025

so that CI runs on #20 before merging

@TWal
Copy link
Contributor Author

TWal commented Jun 13, 2025

Ah, my git-fu was not ideal, I also pushed this commit on main so this PR is useless.

Looks like CI is now run twice, once because we push on a branch of the repo, once because we push on a pull request. That's not a problem if the check is successful because of nix cache, the second run is "for free". However if it fails, it will fail twice because nix doesn't remember failure.

One workaround would be to run CI only on push on main, and on pull requests. However this means that CI on a working branch only runs when we open a corresponding PR.

@TWal TWal closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant