Appeng 4536 multi prompt/model factory#267
Open
heatherzh01 wants to merge 82 commits into
Open
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
gnetanel
force-pushed
the
APPENG-4536_multi_promp_factory
branch
from
July 5, 2026 10:53
84e151a to
026e556
Compare
zvigrinberg
requested changes
Jul 8, 2026
Collaborator
There was a problem hiding this comment.
Hi @heatherzh01 @gnetanel @etsien , Good job all!.
There are still some gaps:
- Code Understanding sub-agent in the agent loop was left untouched ( with all of its components), means that if the gemma/granite models will be configured in agent config, it will still use the hardcoded prompts defined in code understanding sub-agent ( only tested on legacy Llama-3.1), So this is an inconsistency as some parts of the checklist items are being routed and dispatched to the code understanding sub-agent, and not to the reachability sub-agent. might not work well with conjunction to other parts and stages that are using the multi prompts factory prompts' based on the configured model in the agent configuration.
- The dispatcher component in the agent loop, which route a checklist item to the appropriate sub-agent, also stayed untouched.
Same meanings and consequences as the above.
-
RPM Analysis is exempted from this enhancement, worthwhile considering if there is a necessity in apply this multi prompt factory to the RPM Agent as a future enhancement in the future ( POST GA enhancement).
-
You should also make rebase on top of main, to resolve current conflicts, and also to catch up with month and half of new commits added to main, another testing cycle should be conducted afterwards.
-
Please see the rest of my comments in the code.
…endering (#235) Introduce a catalog-driven prompt resolver so vulnerability-analysis prompts can be selected and customized by prompt type, LLM family/version, and programming language without scattering template strings across callers. Co-authored-by: Gal Netanel <gnetanel@redhat.com>
…the module itself (#239) Co-authored-by: Gal Netanel <gnetanel@redhat.com>
…amily and version
… format and minor renaming not to clash language class with other common modules
…is being searched
includes a cursor .mdc file outlining the requirements, setup, and instructions for use (requires a corresponding exploitiq-tests-automation repo to be installed alongside)
It is not called though, because need to figure how to get llm info , see comments for info
A seperate commit has been created for the main branch. In multi prompt feature we generate prompt differently, so a fix is required in here as well.
Missing info is based on llama configuration, this is reflected in the string name that keep the prompt text
It is not called though, because need to figure how to get llm info , see comments for info
A seperate commit has been created for the main branch. In multi prompt feature we generate prompt differently, so a fix is required in here as well.
Missing info is based on llama configuration, this is reflected in the string name that keep the prompt text
Co-authored-by: Zvi Grinberg <75700623+zvigrinberg@users.noreply.github.com>
…db error, vdb disabled, etc.)
…default; document VDB decoupling
heatherzh01
force-pushed
the
APPENG-4536_multi_promp_factory
branch
from
July 17, 2026 02:42
0ce5c55 to
0bcb7cf
Compare
…RHEcosystemAppEng/exploit-iq-agent into APPENG-4536_multi_promp_factory
Collaborator
|
/test-heavy |
zvigrinberg
requested changes
Jul 20, 2026
zvigrinberg
left a comment
zvigrinberg
left a comment
Collaborator
There was a problem hiding this comment.
@heatherzh01 @etsien Only 2 comments after this cycle of review...
After these, and UT + IT + default fallback confusion matrix results are good ( no regression on default for cm) We can merge.
…, add exception rules to summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introducing multi-prompt factory with different configs for different models (gemma, granite, or llama), replacing previous single shared prompt for all models, each model get its own tailored prompts tuned to reasoning styles. Switching models only requires config changes, system will route to correct prompt catalog accordingly.