fix: populate date completed for failed single-repository reports#273
Open
rhartuv wants to merge 2 commits into
Open
fix: populate date completed for failed single-repository reports#273rhartuv wants to merge 2 commits into
rhartuv wants to merge 2 commits into
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
rhartuv
marked this pull request as ready for review
July 19, 2026 08:15
rhartuv
requested review from
IlonaShishov,
vbelouso and
zvigrinberg
as code owners
July 19, 2026 08:15
zvigrinberg
previously approved these changes
Jul 19, 2026
zvigrinberg
left a comment
Collaborator
There was a problem hiding this comment.
@rhartuv LGTM Approved.
Collaborator
|
@rhartuv Kindly rebase ,solve conflicts and retest before merging. |
rhartuv
force-pushed
the
fix/completed-in-single
branch
from
July 19, 2026 10:27
e0d188e to
8bb637b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When a report failed via
updateWithError/POST /api/v1/reports/failed, the UI showed Finding Failed but Date Completed was blank becausereport.completedAtonly came frominput.scan.completed_at, which was never set on failure (SBOM product Date Completed already fell back toerror.at).This change:
input.scan.completed_atto the same instant aserror.atwhen marking failed/expired (if not already set).Report.completedAtfromscan.completed_at, or fromgetReportCompletionTimeonly when anerroris present (so in-progress rows do not incorrectly show Date Requested as Date Completed).completed_aton retry so a retried analysis is not treated as completed.completedstatus filter to require noerrorfield.(Overview metrics are unchanged: they already exclude documents with an
errorfield.)Jira
Before:


After: