Skip to content

fix: refactor finding column logic for excluded components#274

Open
rhartuv wants to merge 2 commits into
RHEcosystemAppEng:mainfrom
rhartuv:fix/excluded-finding
Open

fix: refactor finding column logic for excluded components#274
rhartuv wants to merge 2 commits into
RHEcosystemAppEng:mainfrom
rhartuv:fix/excluded-finding

Conversation

@rhartuv

@rhartuv rhartuv commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the finding display logic in the SBOM table when components are excluded.

Key changes:

  • If 100% of components are excluded, the column now displays a new purple "No components analyzed" label instead of the excluded count.
  • If there is a mix of excluded and analyzed components, the column now respects the existing finding priority (Vulnerable > Uncertain > Not Vulnerable) based only on the analyzed components, hiding the legacy "Excluded" label.

New label:
image
Before:
image

Jira

@rhartuv rhartuv self-assigned this Jul 19, 2026
@rhartuv rhartuv added the enhancement New feature or request label Jul 19, 2026
@vbelouso

vbelouso commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rhartuv
rhartuv marked this pull request as ready for review July 19, 2026 11:03

@zvigrinberg zvigrinberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rhartuv ,

Only minor comment about that.

Thanks.

export function getProductFinding(
productStatus: ProductStatus,
analysisState: string,
_analysisState: string,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhartuv This is not being used anymore, thus can be removed.

@zvigrinberg zvigrinberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhartuv LGTM Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants