feat: filter dashboards by OTEL_SERVICE_NAME#328
Merged
luis5tb merged 2 commits intoJul 14, 2026
Conversation
Make OTEL_SERVICE_NAME a Cloud Build substitution instead of hardcoding it in service.yaml, so each deployment's dashboards and metrics are scoped to the correct agent identity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
luis5tb
added a commit
to luis5tb/google-lightspeed-agent
that referenced
this pull request
Jul 14, 2026
Thread _OTEL_SERVICE_NAME through the GitOps Helm chart to support PR RHEcosystemAppEng#328's configurable OTel service name for dashboard filtering and metrics scoping in multi-instance deployments. - GitOps: falls back to services.agent.name when otelServiceName is not explicitly set, so multi-instance deployments get unique OTel names automatically - deploy.sh: add OTEL_SERVICE_NAME env var with SERVICE_NAME fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
luis5tb
approved these changes
Jul 14, 2026
luis5tb
left a comment
luis5tb
left a comment
Collaborator
There was a problem hiding this comment.
Tested it with the extra GitOps integration and it works as expected
luis5tb
added a commit
to luis5tb/google-lightspeed-agent
that referenced
this pull request
Jul 14, 2026
Thread _OTEL_SERVICE_NAME through the GitOps Helm chart to support PR RHEcosystemAppEng#328's configurable OTel service name for dashboard filtering and metrics scoping in multi-instance deployments. - GitOps: falls back to services.agent.name when otelServiceName is not explicitly set, so multi-instance deployments get unique OTel names automatically - deploy.sh: add OTEL_SERVICE_NAME env var with SERVICE_NAME fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OTEL_SERVICE_NAMEa configurable Cloud Build substitution (_OTEL_SERVICE_NAME) instead of hardcoding it inservice.yamljobmetric label (which carriesOTEL_SERVICE_NAME) instead of the non-existentservice_namelabelstringValueis substituted at deploy time viased, so each deployment's dashboards are scoped to the correct agentdeploy-cloudbuild.shfalls back toSERVICE_NAMEwhenOTEL_SERVICE_NAMEis not setTest plan
make lintpasses_SERVICE_NAMEand confirm dashboards filter byjob=lightspeed-agent--substitutions=_OTEL_SERVICE_NAME=custom-nameand confirm dashboards filter byjob=custom-namedeploy-cloudbuild.shforwardsOTEL_SERVICE_NAMEcorrectlyOTEL_SERVICE_NAME, setSERVICE_NAME=test-agent, confirm_OTEL_SERVICE_NAME=test-agent🤖 Generated with Claude Code