Conversation
…riority items) High priority: - H1: Split TrackingService._track (263→154 lines) into _prepare_tracker, _check_edge_exit, _check_stationary_or_exit (+ M9 guard methods) - H2: Extract paintEvent helpers in overlay.py (202→85 lines): _paint_relationships, _paint_bbox_label, _paint_bbox_handles, _paint_bbox_extras - H3: Split _on_overlay_context_menu (132→20 lines) into _build_bbox_context_menu and _dispatch_bbox_context_action - H4: Split mouseMoveEvent (155→65 lines) into _handle_hover_update, _handle_resize_drag, _handle_rotate_drag - H5: Add pure-logic unit tests for _frames_to_ranges, cascade property description, and CascadeDeltaBBoxCommand do/undo - H6: De-duplicate 3 cascade function pairs via shared _ask_next_frame_range and _execute_cascade_command helpers (~90 lines removed) Medium priority: - M1: Split annotation_ops.py (1834→452 lines) into 6 sub-modules: _annotation_helpers, _annotation_cascade_ops, _annotation_context_menu, _annotation_tracking_ops, _annotation_delete_ops, _annotation_relationship_ops - M2: Extract _validate_tracking_preconditions from _start_tracking - M3: Move _update_overlay_from_model to frame_sync.py, decouple render.py - M4: Rename sidebar signal start_bbox_drawing→new_object_bbox_requested - M5: Split _run_retrack_range in sidebar.py via _validate_retrack_inputs and _run_retrack_loop - M6: Extract _point_in_rotated_rect from hit_test (111→30 lines) - M7: Add BBoxResizedEvent, BBoxRotatedEvent, CascadeApplyEvent dataclasses for Overlay signals with 4+ parameters - M8: Split markit passes.py (2964→25 lines) into 15 per-class files under postprocessing/_passes/ with __init__.py re-exports - M9: Extract _check_edge_exit and _check_stationary_or_exit guard methods Test count: 247 passed, 2 skipped (was 125 edit + 122 markit before) Lint: 0 flake8 errors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.