Add py38 compatibility#5
Merged
Merged
Conversation
This keyword is incompatible with python 3.8. It is not needed here because the code checks around line 714 already whether both lists have the same length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
Compatibility with py3.8 would be more comfortable for me, that is why I am proposing it in this PR.
Details
Very minor adjustments to a single python file are required to create compatibility with 3.8. See the enclosed commits for more details.
The
pyproject.tomlnow requires as minimum Python 3.8. However, when installing the dev dependencies, it is a must that Python 3.12 is used.End users should not be bothered by this, only developers should take care.
For that reason, I have added a note in the
README.mdto explain this.Tests
Passes all tests in the test suite.