fix(menuconfig): allow choice override menuconfig

[MrKevinWeiss]

Hi 👋

I have encountered this issue when spending far too much time with kconfig and RIOT...

Handle special cases when having a choice override with a menuconfig.

This is a bit more complete solution to ulfalizer#94

The failure can be checked with:

config PRE
    bool "Pre prompt"

choice OVERRIDE_ME

menuconfig PRE_MENUCONFIG
    bool "PRE_MENUCONFIG prompt"

config PRE_CONFIG
    bool "PRE_CONFIG prompt"
    depends on PRE_MENUCONFIG

endchoice

menuconfig FOO
    bool "FOO prompt"

if FOO

config FOOPRE
    bool "FOOPRE prompt"

choice OVERRIDE_ME
    bool "OVERRIDE_ME prompt"

menuconfig DOES_NOT_CRASH_MENUCONFIG
    bool "DOES_NOT_CRASH_MENUCONFIG prompt"

config DOES_NOT_CRASH_CONFIG
    bool "DOES_NOT_CRASH_CONFIG prompt"
    depends on DOES_NOT_CRASH_MENUCONFIG

endchoice

config FOOPOST
    bool "FOOPOST prompt"

endif

choice OVERRIDE_ME

menuconfig POST_MENUCONFIG
    bool "POST_MENUCONFIG prompt"

config POST_CONFIG
    bool "POST_CONFIG prompt"
    depends on POST_MENUCONFIG

endchoice

config POST
    bool "POST prompt"

Here is the failure and solution in action...

[MrKevinWeiss]

ping @leandrolanzieri just to do a quick check...

[leandrolanzieri]

ACK. Tested with the provided Kconfig file and indeed it fixes the crash.

[MrKevinWeiss]

Note that this case only trigger if there is a failure, if there is a missing corner-case then the selected node will just be messed up, maybe we could have set _sel_node_i to 0 instead of pass but we will see if anything pops up.

[MrKevinWeiss]

Thanks @leandrolanzieri and @kaspar030