Skip to content

BMS tesseracted#23

Open
mjmagee991 wants to merge 30 commits intomainfrom
feature/mjmagee991/v4-bringup
Open

BMS tesseracted#23
mjmagee991 wants to merge 30 commits intomainfrom
feature/mjmagee991/v4-bringup

Conversation

@mjmagee991
Copy link
Copy Markdown
Contributor

  • Added BQ reset pin
  • Added error LED pin
  • Added reset and error logic to take advantage of new pins

@mjmagee991 mjmagee991 requested a review from a team July 21, 2025 00:36
Copy link
Copy Markdown
Contributor

@aclowmclaughlin aclowmclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- is there a reason that the bq reset wasn't implemented initially?

Not important just curious.

@ActuallyTaylor
Copy link
Copy Markdown
Member

This has been validated on BMS v4 1 & 2. It should be good for merging now.

@ActuallyTaylor ActuallyTaylor marked this pull request as ready for review January 18, 2026 20:08
Copy link
Copy Markdown
Member

@ActuallyTaylor ActuallyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also runs well, I had no problems on the code end when validating the boards. Docs will come in a future PR.

Still needs a lot more work, but it turns out writing good docs is difficult. I will continue to work on this throughout the semester.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
I finished up the documentation for checking the polarity. There is a paragraph style explanation with more detail and a bulleted list that is easier to follow. I aslo added a new command into the bq_interface that will read the current and convert it for you. This removes the need to use a direct memory read and then convert the hexadecimal.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Updated EVT-Core to the latest version, then renamed the DEV namespace to dev because it fits the new EVT core standard

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
@ActuallyTaylor
Copy link
Copy Markdown
Member

ActuallyTaylor commented Feb 6, 2026

I am working on analyzing were the increased FLASH usage is coming from. At the moment, it appears to be a problem with the CI using the newest arm tools, and our development using version 12.

I have also noticed that after updating EVT-Core it seems that even arm tools 12 creates binaries just too big.

It also seems like building for release, consistently adds ~1k extra flash over the debug releases...

Here are elf analysis of 3 build configurations (Debug, Release & CMAKE Build All). These are HTML files generated using an elf analysis tool: BMS Elf Analysis.zip

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Originally, we were always using -Og which optomizas for debugging which increases binary size.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
ActuallyTaylor and others added 7 commits February 7, 2026 11:03
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
This fixes CANopen for the bms. The initialization of CANopen was happening before the board was connected to the CAN network. This led it to just never setting up.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
@ActuallyTaylor ActuallyTaylor changed the title In V4 the BMS Doesn't Work Again BMS tesseracted Feb 24, 2026
@ActuallyTaylor
Copy link
Copy Markdown
Member

The DEV1-BMS target will not build on the CI. The CI is putting out 4% bigger bin files than any physical hardware we have. We are just going to ignore this for now and fix the CI later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants